Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mouseovers in feature details that show field descriptions for VCF fields #1853

Merged
merged 4 commits into from
Apr 1, 2021

Conversation

cmdcolin
Copy link
Collaborator

This adds the ability to inspect the "description" of a particular INFO field entry from a VCF

localhost_3000__config=test_data%2Fconfig_demo json

Modifies the API for BaseFeatureDetails somewhat to use this

Adds an API called getMetadata to the rpcManager, CoreGetMetadata, to get parsed adapter headers that may contain this information

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 26, 2021
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 26, 2021
@cmdcolin cmdcolin force-pushed the vcf_feature_descriptions branch from 0472a99 to 5357e13 Compare March 26, 2021 20:23
@cmdcolin
Copy link
Collaborator Author

This has the possible benefit of being loaded into the feature detail panel at "click-time" so it can survive refresh, but doesn't have to bloat feature objects with info

* Fix color by orientation on CRAM files

* Add some user guide contents on color by orientation
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #1853 (a74b92f) into main (11722a2) will increase coverage by 0.06%.
The diff coverage is 97.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1853      +/-   ##
==========================================
+ Coverage   59.13%   59.20%   +0.06%     
==========================================
  Files         460      460              
  Lines       21414    21436      +22     
  Branches     5023     5028       +5     
==========================================
+ Hits        12664    12692      +28     
+ Misses       8443     8438       -5     
+ Partials      307      306       -1     
Impacted Files Coverage Δ
plugins/variants/src/VariantFeatureWidget/index.js 75.00% <ø> (ø)
packages/core/rpc/coreRpcMethods.ts 86.48% <87.50%> (+0.12%) ⬆️
...kages/core/BaseFeatureWidget/BaseFeatureDetail.tsx 79.54% <100.00%> (+2.93%) ⬆️
...gnments/src/CramAdapter/CramSlightlyLazyFeature.ts 85.93% <100.00%> (+0.14%) ⬆️
...ns/alignments/src/PileupRenderer/PileupRenderer.ts 65.65% <100.00%> (-0.23%) ⬇️
plugins/variants/src/LinearVariantDisplay/model.ts 100.00% <100.00%> (ø)
.../src/VariantFeatureWidget/VariantFeatureWidget.tsx 40.78% <100.00%> (+0.78%) ⬆️
...inearGenomeView/components/RefNameAutocomplete.tsx 93.61% <0.00%> (+4.25%) ⬆️
...ns/variants/src/VcfTabixAdapter/VcfTabixAdapter.ts 93.44% <0.00%> (+4.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11722a2...a74b92f. Read the comment docs.

@rbuels rbuels merged commit fe7b132 into main Apr 1, 2021
@rbuels rbuels deleted the vcf_feature_descriptions branch April 1, 2021 21:26
@rbuels rbuels changed the title Add ability to see the field descriptions for VCF Add mouseovers in feature details that show field descriptions for VCF fields Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants