Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear tracks when using "Return to import form" #1815

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

cmdcolin
Copy link
Collaborator

Reported by https://github.com/li153348734 in the gitter chat, this is a small fix where the tracks remained after using "Return to import form" and changing assemblies but the tracks weren't cleared out https://files.gitter.im/5c59cb65d73408ce4fb6f58e/BIz5/image.png

I checked other options in the linear-genome-view state that might also need to be "cleared" but didn't see any. Any further update that might need clearing can go into "clearView"

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 19, 2021
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 19, 2021
@cmdcolin cmdcolin changed the title Clear tracks when clearing view Clear tracks when clearing view to fix tracks being loaded on wrong assembly with "Return to import form" Mar 19, 2021
@cmdcolin cmdcolin changed the title Clear tracks when clearing view to fix tracks being loaded on wrong assembly with "Return to import form" Clear tracks when using "Return to import form" to prevent tracks being loaded on wrong assembly Mar 19, 2021
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #1815 (cac3527) into master (e2594e3) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1815      +/-   ##
==========================================
- Coverage   58.85%   58.84%   -0.02%     
==========================================
  Files         459      459              
  Lines       21389    21390       +1     
  Branches     5051     5051              
==========================================
- Hits        12589    12587       -2     
- Misses       8489     8492       +3     
  Partials      311      311              
Impacted Files Coverage Δ
...s/linear-genome-view/src/LinearGenomeView/index.ts 83.27% <0.00%> (-0.15%) ⬇️
plugins/alignments/src/BamAdapter/BamAdapter.ts 69.51% <0.00%> (-1.22%) ⬇️
...ments/src/SNPCoverageAdapter/SNPCoverageAdapter.ts 94.16% <0.00%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2594e3...cac3527. Read the comment docs.

@rbuels
Copy link
Contributor

rbuels commented Mar 19, 2021

The diff tab on Github shows a typecheck error coming from the typecheck github action, could you have a look

@cmdcolin cmdcolin force-pushed the clear_tracks_when_clearing_view branch from cb7957e to 7d6cfcf Compare March 19, 2021 17:01
@cmdcolin cmdcolin force-pushed the clear_tracks_when_clearing_view branch from 7d6cfcf to 7d08d57 Compare March 19, 2021 17:30
@cmdcolin cmdcolin changed the title Clear tracks when using "Return to import form" to prevent tracks being loaded on wrong assembly Clear tracks when using "Return to import form" Mar 19, 2021
@cmdcolin cmdcolin merged commit 075df01 into master Mar 22, 2021
@cmdcolin cmdcolin deleted the clear_tracks_when_clearing_view branch March 23, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants