-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to get promoter sequence and intron sequence for genes from the feature details panel #1814
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1814 +/- ##
==========================================
+ Coverage 58.85% 59.12% +0.26%
==========================================
Files 459 460 +1
Lines 21389 21437 +48
Branches 5051 5082 +31
==========================================
+ Hits 12589 12674 +85
+ Misses 8489 8449 -40
- Partials 311 314 +3
Continue to review full report at Codecov.
|
67f98f7
to
e17e140
Compare
60ceeb6
to
2b89cf8
Compare
2b89cf8
to
62c444d
Compare
has a couple more tests for the behavior of the sequence translation into protein, etc. also added react-intersection-observer to only fetch the sequence on demand, so that if a gene with 100 transcripts loaded into the feature details, it avoids overwhelming the feature details panel (only loads data on-demand) this package has a fairly small bundle (1.6kb gzip) and intersectionobserver has good browser support |
b8c6338
to
6e447c3
Compare
This adds some more options to the sequence calculations in feature details
It can get 500bp up/downstream of the gene, and the intron sequence, or a "collapsed intron" with 10bp of the intron sequence around the splice site
Things you'll note while observing this include that upstream and downstream are fetched in a separate request to the main, because I thought it was a little tricky to get the math right for fetching the sequence in one request with the possibility of hitting the start or end of chromosome boundaries, so I figured I would ensure the integrity of the fetch for the main gene body and then do the upstream/downstream separately