Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dotplot rendering outside it's allowed bounds #1793

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

cmdcolin
Copy link
Collaborator

This is a quick fix for #1792

There was some indication in #1764

Instead of laboriously making everything worry about the defaults being geared for the LGV, I make it 0 and then lgv specific use cases can override

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 10, 2021
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 10, 2021
@cmdcolin cmdcolin force-pushed the fix_dotplot_plotting branch from 33989ca to 3310bb9 Compare March 10, 2021 19:24
@cmdcolin cmdcolin changed the title Fix dotplot rendering being incorrect due to interRegionPaddingWidth defaults Fix dotplot rendering outside it's allowed bounds Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #1793 (3310bb9) into master (afdd9e4) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1793      +/-   ##
==========================================
- Coverage   58.66%   58.61%   -0.05%     
==========================================
  Files         457      457              
  Lines       21193    21193              
  Branches     5016     5016              
==========================================
- Hits        12432    12423       -9     
- Misses       8451     8460       +9     
  Partials      310      310              
Impacted Files Coverage Δ
packages/core/util/Base1DViewModel.ts 77.20% <ø> (ø)
...c/LinearGenomeView/components/OverviewScaleBar.tsx 91.89% <ø> (ø)
packages/core/util/blockTypes.ts 73.01% <0.00%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afdd9e4...3310bb9. Read the comment docs.

@rbuels rbuels linked an issue Mar 12, 2021 that may be closed by this pull request
@rbuels rbuels merged commit b17c1e2 into master Mar 17, 2021
@rbuels rbuels deleted the fix_dotplot_plotting branch March 17, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dotplot plotting in the wrong place
2 participants