Add hic aborting and fix remoteAbort signal propagation

[cmdcolin]

This fixes a bug in the remoteAbort call where the signalId was not being passed at all (it was calling {...1} which is just {}, the signal wasn't given a name on the object)

Then it adds a couple points in the hic code where it checks the abort signal, using a timeout to yield to the webworker to process the abortsignal RPC calls

[codecov]

Codecov Report

Merging #1783 (5409f2f) into master (afdd9e4) will decrease coverage by 0.02%.
The diff coverage is 6.25%.

@@            Coverage Diff             @@
##           master    #1783      +/-   ##
==========================================
- Coverage   58.66%   58.63%   -0.03%     
==========================================
  Files         457      457              
  Lines       21193    21206      +13     
  Branches     5016     5017       +1     
==========================================
+ Hits        12432    12434       +2     
- Misses       8451     8462      +11     
  Partials      310      310              

Impacted Files	Coverage Δ
packages/core/rpc/remoteAbortSignals.ts	78.78% <0.00%> (-5.09%)	⬇️
packages/core/util/aborting.ts	64.00% <0.00%> (-16.00%)	⬇️
plugins/hic/src/HicRenderer/HicRenderer.ts	0.00% <0.00%> (ø)
packages/core/rpc/BaseRpcDriver.ts	93.75% <100.00%> (ø)
...inearGenomeView/components/RefNameAutocomplete.tsx	93.61% <0.00%> (+4.25%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afdd9e4...5409f2f. Read the comment docs.

[cmdcolin]

This may have introduced side effect seen here #1785

[teresam856]

Lgtm

[teresam856]

👍

[cmdcolin]

Note that the effect seen in #1785 is visible even if the globalRangeCache is disabled with

diff --git a/packages/core/util/io/rangeFetcher.ts b/packages/core/util/io/rangeFetcher.ts
index f85479f13..9f08e4a03 100644
--- a/packages/core/util/io/rangeFetcher.ts
+++ b/packages/core/util/io/rangeFetcher.ts
@@ -118,7 +118,5 @@ export function clearCache() {
 }

 export function openUrl(url: string): GenericFilehandle {
-  return new RemoteFile(String(url), {
-    fetch: globalCacheFetch,
-  })
+  return new RemoteFile(String(url))
 }

[cmdcolin]

Probably we need to look at AbortablePromiseCache, BAI uses it as an "abortable memoize" and something might be causing it to get purged

[cmdcolin]

This PR is probably good to go but GMOD/abortable-promise-cache#12 should get bumped also

[teresam856]

the date is being used to count for the timeout?

[cmdcolin]

ya, the idea is to check every 400ms for whether an abort has arrived. The hic track can on take up to 5s to do a complete render so it intermittently checks to see if it should cancel

[cmdcolin]

the real trickyness was making sure the abort signal was passed through to the backend. I'm not sure if I have added enough tests to ensure this works but there are a couple added in the BaseRpcDriver...

[teresam856]

gotcha. Now the abort signal is getting passed as a prop?

[cmdcolin]

yep, actually every renderer will get a signal prop it just depends on whether they use it

[cmdcolin]

it would be valuable to use the lessons from this PR to spread it throughout the codebase

[teresam856]

I see, I see.

[cmdcolin]

@rbuels any thoughts on this? would be good to merge with the abortable-promise-cache PR(s) too

[cmdcolin]

there could be more advanced tests because this technically does not test remote abort but I wasn't sure how to instrument that yet