-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color picker and choice of summary score style for wiggle track #1743
Conversation
c839338
to
fe7941c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1743 +/- ##
==========================================
- Coverage 58.73% 58.67% -0.07%
==========================================
Files 455 456 +1
Lines 21049 21078 +29
Branches 4987 4990 +3
==========================================
+ Hits 12364 12367 +3
- Misses 8376 8402 +26
Partials 309 309
Continue to review full report at Codecov.
|
b75779d
to
3b3847d
Compare
I tagged this discuss in meeting because of the duplication of config items in state. As noted above there are pros and cons. This was also brought up last week but the idea was that it seemed ok, but is there a point where it is too much |
What if we had a chained config-reading thing that looked like:
would return the first non-default in the chain, or the default if none set |
3b3847d
to
12d756e
Compare
41a4604
to
a1330a9
Compare
Regarding the above comment, we probably wouldn't want to "validate that they have the same config schema" (because the top le vel config would not have track name, track description, track id, etc.) but it could be an option. However this would likely be a future thing (that may break sessions if we change a lot of things) because most of the track menu item logic is manual and involves normal MST state instead of config objects. The above comment might apply to a more advanced future config layers idea |
a1330a9
to
433b712
Compare
This adds a simple color picker for the wiggle track
This is almost going too far in a way, and I believe is starting to call into question the duplication of config items into state
I believe the user experience of having to clone a track and use our config editor is not ideal, and I think the track state and track menu helps, but it is causing duplication of code.
However, I also see that the continued use of track state as a way to open up a new opportunity: it offers a conceptually nice way to get config layers:I can simply say something like
Then I can get a "global setting" to apply to all my wiggle tracks a la config layers. This would be otherwise difficult to setup on every individual wiggle track
So there are tradeoffs here, but open to ideas.
Note that other track types like FeatureTrack could enjoy a color picker also