-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually adjust feature height and spacing on alignments track #1721
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1721 +/- ##
==========================================
- Coverage 58.82% 58.73% -0.09%
==========================================
Files 448 449 +1
Lines 20754 20785 +31
Branches 4919 4924 +5
==========================================
+ Hits 12208 12209 +1
- Misses 8239 8269 +30
Partials 307 307
Continue to review full report at Codecov.
|
b266d66
to
8ee6560
Compare
Any objection? I think the functionality can be good Inspired by https://twitter.com/lh3lh3/status/1362921612690010118 has a nice compact visualization but also had that previous issue open for making compact reads |
seems fine. wouldn't setting these things be a little bit nicer in the sidebar than with dialogs though, so you can see the changes as you tweak it? |
It is difficult to get live update right. Our live update can be quite slow and really clobbers the system with too much activity, see this new issue for example #1730 it is slow to drag the height of the track down because it so rapidly produces re-rendering requests that go through the whole rpc pipeline that it ends up being slow |
This allows both manually adjusting feature height and spacing between features via toggling pitchY to 1 using a track setting
Example
For #1693