Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually adjust feature height and spacing on alignments track #1721

Merged
merged 4 commits into from
Feb 23, 2021

Conversation

cmdcolin
Copy link
Collaborator

This allows both manually adjusting feature height and spacing between features via toggling pitchY to 1 using a track setting

Example

localhost_3000__config=test_data%2Fconfig_demo json session=local-mn0hpkxC9

For #1693

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 20, 2021
@cmdcolin cmdcolin changed the title Manually adjust feature height and spacing Manually adjust feature height and spacing on alignments track Feb 20, 2021
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Feb 20, 2021
@codecov
Copy link

codecov bot commented Feb 20, 2021

Codecov Report

Merging #1721 (8ee6560) into master (e2f5843) will decrease coverage by 0.08%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1721      +/-   ##
==========================================
- Coverage   58.82%   58.73%   -0.09%     
==========================================
  Files         448      449       +1     
  Lines       20754    20785      +31     
  Branches     4919     4924       +5     
==========================================
+ Hits        12208    12209       +1     
- Misses       8239     8269      +30     
  Partials      307      307              
Impacted Files Coverage Δ
...src/LinearPileupDisplay/components/FilterByTag.tsx 5.00% <ø> (ø)
...s/src/LinearPileupDisplay/components/SortByTag.tsx 7.14% <ø> (ø)
...ns/alignments/src/PileupRenderer/PileupRenderer.ts 65.75% <0.00%> (-0.23%) ⬇️
...inearPileupDisplay/components/SetFeatureHeight.tsx 5.88% <5.88%> (ø)
...lugins/alignments/src/LinearPileupDisplay/model.ts 70.28% <26.66%> (-4.57%) ⬇️
...pluggableElementTypes/renderers/BoxRendererType.ts 85.13% <100.00%> (+0.20%) ⬆️
...inearGenomeView/components/RefNameAutocomplete.tsx 89.36% <0.00%> (-4.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2f5843...8ee6560. Read the comment docs.

@cmdcolin cmdcolin force-pushed the adjust_feature_height branch from b266d66 to 8ee6560 Compare February 20, 2021 19:35
@cmdcolin
Copy link
Collaborator Author

Any objection? I think the functionality can be good

Inspired by https://twitter.com/lh3lh3/status/1362921612690010118 has a nice compact visualization but also had that previous issue open for making compact reads

@rbuels
Copy link
Contributor

rbuels commented Feb 23, 2021

seems fine. wouldn't setting these things be a little bit nicer in the sidebar than with dialogs though, so you can see the changes as you tweak it?

@rbuels rbuels merged commit 720894f into master Feb 23, 2021
@rbuels rbuels deleted the adjust_feature_height branch February 23, 2021 19:16
@cmdcolin
Copy link
Collaborator Author

It is difficult to get live update right. Our live update can be quite slow and really clobbers the system with too much activity, see this new issue for example #1730 it is slow to drag the height of the track down because it so rapidly produces re-rendering requests that go through the whole rpc pipeline that it ends up being slow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants