Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Show all regions in assembly" to import form and make import form show entire region when refName selected #1704

Merged
merged 4 commits into from
Feb 19, 2021

Conversation

cmdcolin
Copy link
Collaborator

This is a proposal for a couple more navigation features in the lgv

  • "Show all regions in assembly" button on importform
  • "Return to import form" view menu item
  • Add showAllRegions after importform navigation. This causes, for example, if LGV refName chr1 is selected, that the entire chr1 is put into view instead of a small window from chr1:1-1000 that we see currently

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 17, 2021
@cmdcolin cmdcolin changed the title Add show all regions to assembly to import form and make import form view whole refseq when a refName is selected Add "Show all regions in assembly" to import form and make import form show entire region when refName selected Feb 17, 2021
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Feb 17, 2021
@cmdcolin
Copy link
Collaborator Author

screenshot of the new import form

localhost_3000__config=test_data%2Fconfig json session=local-0TFtG0hDi

@cmdcolin cmdcolin force-pushed the proposal_importform_nav branch from 5edf71a to 0e9e25d Compare February 17, 2021 02:04
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #1704 (0e9e25d) into master (734e00a) will decrease coverage by 0.01%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1704      +/-   ##
==========================================
- Coverage   58.89%   58.88%   -0.02%     
==========================================
  Files         446      446              
  Lines       20468    20475       +7     
  Branches     4824     4824              
==========================================
+ Hits        12055    12056       +1     
- Misses       8115     8121       +6     
  Partials      298      298              
Impacted Files Coverage Δ
...s/linear-genome-view/src/LinearGenomeView/index.ts 83.84% <0.00%> (-0.61%) ⬇️
...iew/src/LinearGenomeView/components/ImportForm.tsx 74.54% <33.33%> (-2.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 734e00a...0e9e25d. Read the comment docs.

@rbuels
Copy link
Contributor

rbuels commented Feb 22, 2021

you know, I was thinking about this again just now, and it seems to me that "show all regions" would make more sense as stateful slider switch between "show first region / show all regions" than as a separate button. With the current button, it's a little confusing to the user whether the "show all regions" button does the same thing as "open", or what

@cmdcolin
Copy link
Collaborator Author

Does this need reopening? I'm open to a design review, but I don't really think a slider switch is my preferred design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants