-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Show all regions in assembly" to import form and make import form show entire region when refName selected #1704
Conversation
…m after returning to it
5edf71a
to
0e9e25d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1704 +/- ##
==========================================
- Coverage 58.89% 58.88% -0.02%
==========================================
Files 446 446
Lines 20468 20475 +7
Branches 4824 4824
==========================================
+ Hits 12055 12056 +1
- Misses 8115 8121 +6
Partials 298 298
Continue to review full report at Codecov.
|
plugins/linear-genome-view/src/LinearGenomeView/components/ImportForm.tsx
Show resolved
Hide resolved
you know, I was thinking about this again just now, and it seems to me that "show all regions" would make more sense as stateful slider switch between "show first region / show all regions" than as a separate button. With the current button, it's a little confusing to the user whether the "show all regions" button does the same thing as "open", or what |
Does this need reopening? I'm open to a design review, but I don't really think a slider switch is my preferred design |
This is a proposal for a couple more navigation features in the lgv
showAllRegions
after importform navigation. This causes, for example, if LGV refName chr1 is selected, that the entire chr1 is put into view instead of a small window from chr1:1-1000 that we see currently