-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCContent adapter #1624
GCContent adapter #1624
Conversation
f3e0984
to
5e5c3f3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1624 +/- ##
==========================================
- Coverage 59.21% 59.01% -0.21%
==========================================
Files 441 444 +3
Lines 20274 20356 +82
Branches 4669 4681 +12
==========================================
+ Hits 12006 12013 +7
- Misses 7969 8044 +75
Partials 299 299
Continue to review full report at Codecov.
|
Looks like there is a build error related to the direct import of statsUtils...could consider more properly exporting the statsUtils another way but that is a weird error |
Now that our plugins can be built independently, we can't import from |
This should be ready basically. We could potentially automatically generate a gccontent track for the assembly to make this more accessible to users, but the adapter type works pretty fine here |
There is some note in #1630 that the region stats code may get added to base adapter so all the adapters that use stats don't have to implement it in a custom way |
This is a sketch for a GCContent adapter
Ref #281
Imports some utility functions from @jbrowse/plugin-wiggle, uses the sequenceAdapter/subadapter concept similar to CramAdapter, and there is a track is in config_demo.json for hg19