Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCContent adapter #1624

Merged
merged 2 commits into from
Jan 22, 2021
Merged

GCContent adapter #1624

merged 2 commits into from
Jan 22, 2021

Conversation

cmdcolin
Copy link
Collaborator

This is a sketch for a GCContent adapter

Ref #281

Imports some utility functions from @jbrowse/plugin-wiggle, uses the sequenceAdapter/subadapter concept similar to CramAdapter, and there is a track is in config_demo.json for hg19

localhost_3000__config=test_data%2Fconfig_demo json session=local-947DkYCtt (2)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jan 19, 2021
@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #1624 (e424990) into master (326b357) will decrease coverage by 0.20%.
The diff coverage is 8.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1624      +/-   ##
==========================================
- Coverage   59.21%   59.01%   -0.21%     
==========================================
  Files         441      444       +3     
  Lines       20274    20356      +82     
  Branches     4669     4681      +12     
==========================================
+ Hits        12006    12013       +7     
- Misses       7969     8044      +75     
  Partials      299      299              
Impacted Files Coverage Δ
...ins/wiggle/src/LinearWiggleDisplay/models/model.ts 75.69% <ø> (ø)
.../sequence/src/GCContentAdapter/GCContentAdapter.ts 1.31% <1.31%> (ø)
...gins/sequence/src/GCContentAdapter/configSchema.ts 100.00% <100.00%> (ø)
plugins/sequence/src/GCContentAdapter/index.ts 100.00% <100.00%> (ø)
plugins/sequence/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 326b357...e424990. Read the comment docs.

@cmdcolin
Copy link
Collaborator Author

Looks like there is a build error related to the direct import of statsUtils...could consider more properly exporting the statsUtils another way but that is a weird error

@garrettjstevens
Copy link
Collaborator

Now that our plugins can be built independently, we can't import from src of other plugins. Anything you want to use from the other plugin has to be exported at the top level of that plugin.

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jan 19, 2021
@cmdcolin
Copy link
Collaborator Author

This should be ready basically. We could potentially automatically generate a gccontent track for the assembly to make this more accessible to users, but the adapter type works pretty fine here

@cmdcolin
Copy link
Collaborator Author

There is some note in #1630 that the region stats code may get added to base adapter so all the adapters that use stats don't have to implement it in a custom way

@rbuels rbuels merged commit 8a29c3d into master Jan 22, 2021
@rbuels rbuels deleted the gccontent_adapter branch January 22, 2021 18:43
@cmdcolin cmdcolin mentioned this pull request Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants