Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some features that are missing from jbrowse 2 to the feature comparison table #1581

Merged
merged 2 commits into from
Dec 23, 2020

Conversation

cmdcolin
Copy link
Collaborator

Xref #1580

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #1581 (8a6e57d) into master (25d67d7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1581   +/-   ##
=======================================
  Coverage   59.44%   59.44%           
=======================================
  Files         435      435           
  Lines       19620    19620           
  Branches     4587     4587           
=======================================
  Hits        11663    11663           
  Misses       7663     7663           
  Partials      294      294           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25d67d7...8a6e57d. Read the comment docs.

@rbuels
Copy link
Contributor

rbuels commented Dec 22, 2020

If you put the lack of URL query stuff in, you should add the embedded functionality ;-)

@cmdcolin
Copy link
Collaborator Author

What do you mean by "embedded functionality"?

@cmdcolin
Copy link
Collaborator Author

You mean the react lgv component?

@rbuels
Copy link
Contributor

rbuels commented Dec 22, 2020

yes the react component

@cmdcolin
Copy link
Collaborator Author

I added a section about embeddability, it is hard to be super concise for it to be simply put in the simple feature comparison so the section helps expand on a couple things.

@cmdcolin cmdcolin force-pushed the add_missing_features_to_website branch from d4d07a0 to e1dff03 Compare December 23, 2020 01:30
@cmdcolin cmdcolin force-pushed the add_missing_features_to_website branch from e1dff03 to 8a6e57d Compare December 23, 2020 01:48
@rbuels rbuels merged commit 8cb0956 into master Dec 23, 2020
@rbuels rbuels deleted the add_missing_features_to_website branch December 23, 2020 17:05
@garrettjstevens garrettjstevens added needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) documentation and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants