Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create --branch and --nightly flags for jbrowse create and jbrowse upgrade commands #1579

Merged
merged 5 commits into from
Dec 22, 2020

Conversation

cmdcolin
Copy link
Collaborator

This re-instates the upload of a jbrowse-web build to the folder where it is being deployed (this existed in travis but was lost in the github move)

Then it also adds a --branch and a --nightly (alias for --branch master) flags to the jbrowse create and jbrowse upgrade commands

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #1579 (4398493) into master (25d67d7) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1579      +/-   ##
==========================================
- Coverage   59.44%   59.44%   -0.01%     
==========================================
  Files         435      435              
  Lines       19620    19628       +8     
  Branches     4587     4593       +6     
==========================================
+ Hits        11663    11667       +4     
- Misses       7663     7667       +4     
  Partials      294      294              
Impacted Files Coverage Δ
products/jbrowse-cli/src/base.ts 84.72% <0.00%> (-2.43%) ⬇️
products/jbrowse-cli/src/commands/create.ts 88.88% <100.00%> (+0.79%) ⬆️
products/jbrowse-cli/src/commands/upgrade.ts 82.35% <100.00%> (+1.70%) ⬆️
...inearGenomeView/components/RefNameAutocomplete.tsx 86.20% <0.00%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25d67d7...4398493. Read the comment docs.

Copy link
Contributor

@rbuels rbuels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great functionality, I think just tweak the docs to make it clear that using these flags get a "development build" or an "experimental build" that isn't official

products/jbrowse-cli/README.md Outdated Show resolved Hide resolved
products/jbrowse-cli/README.md Outdated Show resolved Hide resolved
@rbuels rbuels merged commit 3c92388 into master Dec 22, 2020
@rbuels rbuels deleted the create_nightly branch December 22, 2020 19:05
@cmdcolin cmdcolin added the enhancement New feature or request label Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants