Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid errors from breakpoint split view related to getBoundingClientRect on null track #1559

Merged
merged 1 commit into from
Dec 13, 2020

Conversation

cmdcolin
Copy link
Collaborator

s3 amazonaws com_jbrowse org_code_jb2_v1 0 2_index html_session=local-Go9biLRff

Seen on master while flipping through SV inspector and launching breakpoint split views

@cmdcolin cmdcolin added the bug Something isn't working label Dec 13, 2020
@codecov
Copy link

codecov bot commented Dec 13, 2020

Codecov Report

Merging #1559 (b75f025) into master (9b27355) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1559      +/-   ##
==========================================
+ Coverage   59.50%   59.51%   +0.01%     
==========================================
  Files         435      435              
  Lines       19556    19557       +1     
  Branches     4561     4562       +1     
==========================================
+ Hits        11636    11640       +4     
+ Misses       7626     7623       -3     
  Partials      294      294              
Impacted Files Coverage Δ
plugins/breakpoint-split-view/src/util.ts 9.52% <0.00%> (-0.48%) ⬇️
packages/core/util/analytics.ts 86.48% <0.00%> (+2.70%) ⬆️
...inearGenomeView/components/RefNameAutocomplete.tsx 89.65% <0.00%> (+3.44%) ⬆️
...r-view/src/BaseChordDisplay/components/Loading.tsx 100.00% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b27355...b75f025. Read the comment docs.

@cmdcolin
Copy link
Collaborator Author

This is somewhat weird and hard to trigger. Maybe merge this for now and if we see anything weird where squiggles are not drawn properly (e.g. uses the height 0 branch from this) then we can re-examine

@cmdcolin cmdcolin marked this pull request as ready for review December 13, 2020 22:22
@cmdcolin cmdcolin merged commit d8ca43a into master Dec 13, 2020
@cmdcolin cmdcolin changed the title Avoid errors from breakpoint split view related to getBoundingClientRect Avoid errors from breakpoint split view related to getBoundingClientRect on null track Dec 13, 2020
@cmdcolin cmdcolin deleted the fix_null_getboundingclientrect branch December 13, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant