Change track selector togglebutton to normal button

[cmdcolin]

This code has been a tricky thing to maintain properly since it pokes deeply into the state of the drawerwidget, so I propose removing it. Alternatively we could refactor to extract this, but another area of the code (the "Select tracks" button) removed the toggle state already.

fixes #1411
fixes #1499

[cmdcolin]

Another random redesign proposal added here...

Add the literal text "open track selector" always on this panel, just in case people become very lost trying to open the track selector?

[rbuels]

what if we added isAssociatedWith(thing: any): boolean to the API of widget
this would be a view with parameters on the MST model of the widget

and the default implementation of it is () => false

[cmdcolin]

Note that there is no BaseWidgetModel, so we can't assume isAssociatedWith is on the API necessarily unless we want to crash for this purpose, and so the expression that is used in many places in the code looks like

              isSessionModelWithWidgets(session) &&  session.visibleWidget?.isAssociatedWith?.(self.id),

It is fairly cumbersome, but is a one liner that we can implement

[cmdcolin]

Refer to https://github.com/GMOD/jbrowse-components/compare/isassociatedwith for diff with master for this change

[cmdcolin]

Any thought on whether we could merge this PR as is?
I think that the setting of the disabled state seems to have been obsoleted by #1354

The alternative isAssociatedWith stuff isn't super elegant so codewise I basically prefer this unless it's desirable to keep the disabled state

[rbuels]

Can you confirm this fixes both #1411 and #1499?

[cmdcolin]

Yep, fixes both

[cmdcolin]

The original screenshot here proposed having the literal text "Open track selector" visible in the header but I removed that for a little more brevity for now

[codecov]

Codecov Report

Merging #1442 (4a06dd5) into master (34eddf1) will increase coverage by 0.00%.
The diff coverage is 20.00%.

@@           Coverage Diff           @@
##           master    #1442   +/-   ##
=======================================
  Coverage   59.47%   59.48%           
=======================================
  Files         435      435           
  Lines       19547    19512   -35     
  Branches     4581     4552   -29     
=======================================
- Hits        11625    11606   -19     
+ Misses       7623     7607   -16     
  Partials      299      299           

Impacted Files	Coverage Δ
...tplot-view/src/DotplotView/components/Controls.tsx	42.85% <ø> (-4.52%)	⬇️
plugins/dotplot-view/src/DotplotView/model.ts	46.51% <ø> (+0.22%)	⬆️
...omparative-view/src/LinearComparativeView/model.ts	10.00% <ø> (+0.52%)	⬆️
...me-view/src/LinearGenomeView/components/Header.tsx	78.84% <ø> (-1.86%)	⬇️
...s/linear-genome-view/src/LinearGenomeView/index.ts	83.72% <ø> (-0.19%)	⬇️
...roducts/jbrowse-desktop/src/sessionModelFactory.ts	1.68% <0.00%> (+0.02%)	⬆️
products/jbrowse-web/src/sessionModelFactory.ts	62.50% <0.00%> (+0.64%)	⬆️
...r-view/src/CircularView/components/CircularView.js	89.47% <100.00%> (-0.65%)	⬇️
...ins/wiggle/src/LinearWiggleDisplay/models/model.ts	82.88% <0.00%> (+0.90%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34eddf1...4a06dd5. Read the comment docs.