Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1381 improve assembly add form #1439

Merged
merged 9 commits into from
Nov 16, 2020
Merged

Conversation

elliothershberg
Copy link
Member

This PR improves the form and workflow for adding a new assembly graphically.

Previously

image

Would accept a name, and then immediately direct the user to the full configEditor for the assembly.

Now

image

A simple form that asks for name and adapter info (IndexedFastaAdapter, BgzipFastaAdapter, or TwoBitAdapter)

when submitted, the user gets notified:

image

and then returned to the main table of assemblies. Any more granular editing can be accessed through the pencil icon which gives access to the full configEditor.

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #1439 (8ab6044) into master (9b9818b) will decrease coverage by 0.06%.
The diff coverage is 59.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1439      +/-   ##
==========================================
- Coverage   59.58%   59.52%   -0.07%     
==========================================
  Files         425      425              
  Lines       18990    19029      +39     
  Branches     4442     4454      +12     
==========================================
+ Hits        11316    11327      +11     
- Misses       7384     7409      +25     
- Partials      290      293       +3     
Impacted Files Coverage Δ
...management/src/AssemblyManager/AssemblyManager.tsx 73.68% <ø> (-18.43%) ⬇️
products/jbrowse-desktop/src/jbrowseModel.js 19.29% <0.00%> (-0.35%) ⬇️
...management/src/AssemblyManager/AssemblyAddForm.tsx 66.66% <60.00%> (-33.34%) ⬇️
products/jbrowse-web/src/jbrowseModel.js 73.61% <100.00%> (+0.37%) ⬆️
...-management/src/AssemblyManager/AssemblyEditor.tsx 33.33% <0.00%> (-66.67%) ⬇️
plugins/alignments/src/BamAdapter/BamAdapter.ts 69.51% <0.00%> (-1.22%) ⬇️
...ments/src/SNPCoverageAdapter/SNPCoverageAdapter.ts 89.92% <0.00%> (-0.78%) ⬇️
packages/core/util/index.ts 83.95% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b9818b...8ab6044. Read the comment docs.

@rbuels rbuels merged commit 52096e7 into master Nov 16, 2020
@rbuels rbuels deleted the 1381_improve_assembly_add_form branch November 16, 2020 19:08
@garrettjstevens garrettjstevens added the enhancement New feature or request label Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants