Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to quickstart guides #1435

Merged
merged 5 commits into from
Nov 13, 2020
Merged

Updates to quickstart guides #1435

merged 5 commits into from
Nov 13, 2020

Conversation

garrettjstevens
Copy link
Collaborator

While pairing with each of @teresam856, @peterkxie, and @elliothershberg yesterday, we went through an exercise of trying to approach JBrowse from the point of view of someone who is brand new to it. While doing so, we made some proposed changes to the quickstart guides.

The proposed flow is to have three guides. First is the general quickstart which installs the JBrowse CLI, downloads JBrowse, and makes sure it's working. The users then have the choice to proceed with configuring JBrowse by using the CLI config quickstart or the GUI config quickstart.

This also adjust some formatting and wording and adds some screenshots so users can confirm that what they've done is successful.

garrettjstevens and others added 4 commits November 9, 2020 16:44
Co-authored-by: Teresa Martinez <tere486martinez@gmail.com>
Co-authored-by: Peter Xie <peterkxie@yahoo.com>
Co-authored-by: Elliot Hershberg <eahershberg@gmail.com>
Copy link
Contributor

@rbuels rbuels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a great idea, I was actually going to suggest pretty much exactly this in grooming this friday!

![JBrowse 2 linear genome view with variant track](./img/volvox_variants.png)

## Conclusion

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the flow of this quickstart!

Copy link
Contributor

@teresam856 teresam856 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cmdcolin
Copy link
Collaborator

I would prefer the CLI one gets rolled into the web quick-start, and the admin-server keeps being called admin-server guide

@cmdcolin
Copy link
Collaborator

The comment says "The proposed flow is to have three guides." but there are four now, and I think that adding tracks via the CLI is a logical extension to the web quick start

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #1435 (aaee066) into master (9b9818b) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1435      +/-   ##
==========================================
+ Coverage   59.58%   59.63%   +0.04%     
==========================================
  Files         425      425              
  Lines       18990    18990              
  Branches     4442     4445       +3     
==========================================
+ Hits        11316    11325       +9     
+ Misses       7384     7376       -8     
+ Partials      290      289       -1     
Impacted Files Coverage Δ
products/jbrowse-cli/src/base.ts 87.32% <0.00%> (-0.18%) ⬇️
plugins/variants/src/VcfTabixAdapter/VcfFeature.ts 80.61% <0.00%> (+0.19%) ⬆️
...lignments/src/BamAdapter/BamSlightlyLazyFeature.ts 79.24% <0.00%> (+1.88%) ⬆️
...ment/src/AddTrackWidget/components/ConfirmTrack.js 59.01% <0.00%> (+4.91%) ⬆️
...s/svg/src/SvgFeatureRenderer/components/Chevron.js 89.74% <0.00%> (+10.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b9818b...6ccd44d. Read the comment docs.

@garrettjstevens
Copy link
Collaborator Author

The comment says "The proposed flow is to have three guides."

Sorry, should have been clearer. I meant that the two guides we looked at would be split into three guides. We didn't look at the desktop guide.

Copy link
Member

@elliothershberg elliothershberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this restructuring of the quickstart, looks good to me 👍

files. See [configuring assemblies](config_guide#assembly-config) for more info
on formats supported for the sequence file.

:::note
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the restructuring here


If you have your JBrowse 2
[running as described](quickstart_web#running-jbrowse-2) in the JBrowse web
quickstart, you can refresh the page and an add a linear genome view of the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these kind of descriptions, is it worth adding the path in the menu? I.e. add a linear genome view (File -> Add -> Linear Genome View)

@garrettjstevens garrettjstevens marked this pull request as ready for review November 13, 2020 19:49
@rbuels rbuels merged commit bd0d996 into master Nov 13, 2020
@rbuels rbuels deleted the gs_docs branch November 13, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants