Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection tracks not showing up in track selector #1431

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

garrettjstevens
Copy link
Collaborator

@garrettjstevens garrettjstevens commented Nov 10, 2020

Fixes a bug introduced in #1398. This makes the connection track filtering logic the same as the regular track filtering.

Fixes #1424

@garrettjstevens garrettjstevens self-assigned this Nov 10, 2020
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #1431 (4e2e1fa) into master (ee3d90c) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1431   +/-   ##
=======================================
  Coverage   59.60%   59.61%           
=======================================
  Files         425      425           
  Lines       18990    18997    +7     
  Branches     4445     4446    +1     
=======================================
+ Hits        11319    11325    +6     
  Misses       7382     7382           
- Partials      289      290    +1     
Impacted Files Coverage Δ
...ement/src/HierarchicalTrackSelectorWidget/model.js 69.41% <0.00%> (-6.23%) ⬇️
...lignments/src/BamAdapter/BamSlightlyLazyFeature.ts 79.24% <0.00%> (+1.88%) ⬆️
...s/svg/src/SvgFeatureRenderer/components/Chevron.js 89.74% <0.00%> (+10.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee3d90c...4e2e1fa. Read the comment docs.

@cmdcolin
Copy link
Collaborator

lgtm...I guess my only thought is that now many different areas of the code like showTrack, and this, etc. here have to be concerned with looping through displays...wonder if it can be made more simple somehow

@cmdcolin cmdcolin merged commit b1022c8 into master Nov 12, 2020
@garrettjstevens garrettjstevens added the bug Something isn't working label Nov 23, 2020
@cmdcolin cmdcolin deleted the fix_connection_tracksel branch March 19, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support composite tracks from ucsc trackhubs
2 participants