Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove savedSessions from configs #1383

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Remove savedSessions from configs #1383

merged 1 commit into from
Nov 3, 2020

Conversation

garrettjstevens
Copy link
Collaborator

savedSessions no longer gets loaded from the config file after #1240. This removes references to it in demo configs, and moves a saved session to defaultSession where applicable.

It doesn't exist anymore. Set former savedSession as defaultSession
where applicable.
@garrettjstevens garrettjstevens self-assigned this Nov 3, 2020
@garrettjstevens
Copy link
Collaborator Author

Easier to view the diff hiding whitespace: https://github.com/GMOD/jbrowse-components/pull/1383/files?diff=split&w=1

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #1383 into master will decrease coverage by 0.02%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1383      +/-   ##
==========================================
- Coverage   59.42%   59.40%   -0.03%     
==========================================
  Files         418      418              
  Lines       18680    18683       +3     
  Branches     4402     4404       +2     
==========================================
- Hits        11101    11098       -3     
- Misses       7286     7290       +4     
- Partials      293      295       +2     
Impacted Files Coverage Δ
...iew/src/LinearGenomeView/components/ImportForm.tsx 66.66% <ø> (ø)
...c/LinearGenomeView/components/LinearGenomeView.tsx 79.16% <ø> (-4.17%) ⬇️
products/jbrowse-web/src/Loader.tsx 71.35% <0.00%> (ø)
...ment/src/AddTrackWidget/components/ConfirmTrack.js 48.57% <27.27%> (-5.53%) ⬇️
packages/core/util/index.ts 83.61% <0.00%> (+0.34%) ⬆️
packages/core/util/analytics.ts 77.50% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b95e14...8d9ced4. Read the comment docs.

@cmdcolin
Copy link
Collaborator

cmdcolin commented Nov 3, 2020

This could be a different discussion but I believe there is room for something like exampleSessions, something an admin can configure to demo their instance.

So just rename savedSessions to exampleSessions?

@garrettjstevens
Copy link
Collaborator Author

I agree that would be a good follow-on, it's similar to the sessionTemplates idea I've talked about before, and maybe they could have their own section on the splash screen. For now I think we need this, though, since there are sessions in the demo configs that we are currently unable to access.

@cmdcolin cmdcolin merged commit 8edf64a into master Nov 3, 2020
@cmdcolin
Copy link
Collaborator

cmdcolin commented Nov 3, 2020

xref #1384 for that follow on

@cmdcolin cmdcolin deleted the remove_savedSessions branch November 3, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants