Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-remove tracks with non valid config references in view->afterAttach #1275

Closed
wants to merge 3 commits into from

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Oct 6, 2020

Ref
#560

Procedure to test

Open a couple tracks
Delete one of those tracks from the config.json
Refresh the page

Expect: The track that was deleted will not be present on the refreshed page

Note that "all views would need to implement this functionality" as implemented here

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #1275 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1275      +/-   ##
==========================================
+ Coverage   58.84%   58.86%   +0.01%     
==========================================
  Files         415      415              
  Lines       18065    18071       +6     
  Branches     4213     4213              
==========================================
+ Hits        10630    10637       +7     
+ Misses       7163     7162       -1     
  Partials      272      272              
Impacted Files Coverage Δ
...s/linear-genome-view/src/LinearGenomeView/index.ts 76.89% <100.00%> (+0.26%) ⬆️
packages/core/util/index.ts 81.50% <0.00%> (ø)
packages/core/rpc/coreRpcMethods.ts 86.88% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3820ad0...a8e3468. Read the comment docs.

@cmdcolin cmdcolin requested a review from rbuels October 6, 2020 23:05
@cmdcolin cmdcolin force-pushed the autoremove_nonworking_tracks branch from 755c8a1 to a8e3468 Compare October 6, 2020 23:08
@rbuels
Copy link
Contributor

rbuels commented Oct 6, 2020

any way we can avoid all views having to do this?

maybe walk the state tree and validate all the references someplace central?

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Oct 6, 2020

Not sure. I tried doing a walk in session->afterAttach but only the session itself was returned....the timing is important for this because it has to remove the bad tracks before they get rendered...otherwise have to do crazy stuff to make everything involved in rendering a track robust to getConf throwing exceptions

@cmdcolin cmdcolin marked this pull request as ready for review October 23, 2020 18:52
@cmdcolin cmdcolin marked this pull request as draft October 23, 2020 18:52
@rbuels rbuels self-assigned this Oct 28, 2020
@cmdcolin
Copy link
Collaborator Author

close by #1353

@cmdcolin cmdcolin closed this Oct 31, 2020
@cmdcolin cmdcolin deleted the autoremove_nonworking_tracks branch January 8, 2021 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants