Skip to content

Commit

Permalink
More test fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
cmdcolin committed Mar 4, 2021
1 parent bc06592 commit d06760f
Show file tree
Hide file tree
Showing 4 changed files with 230 additions and 357 deletions.
216 changes: 76 additions & 140 deletions packages/core/BaseFeatureWidget/__snapshots__/index.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -2,179 +2,115 @@

exports[`open up a widget 1`] = `
<div
class="MuiPaper-root makeStyles-paperRoot MuiPaper-elevation1 MuiPaper-rounded"
class="MuiPaper-root MuiAccordion-root makeStyles-accordionBorder MuiAccordion-expanded MuiAccordion-rounded MuiPaper-elevation1 MuiPaper-rounded"
>
<div
class="MuiPaper-root MuiAccordion-root MuiAccordion-expanded MuiAccordion-rounded MuiPaper-elevation1 MuiPaper-rounded"
style="margin-top: 4px;"
aria-disabled="false"
aria-expanded="true"
class="MuiButtonBase-root MuiAccordionSummary-root MuiAccordionSummary-expanded"
role="button"
tabindex="0"
>
<div
aria-disabled="false"
aria-expanded="true"
class="MuiButtonBase-root MuiAccordionSummary-root MuiAccordionSummary-expanded"
role="button"
tabindex="0"
class="MuiAccordionSummary-content MuiAccordionSummary-expanded"
>
<div
class="MuiAccordionSummary-content MuiAccordionSummary-expanded"
<span
class="MuiTypography-root MuiTypography-button"
>
<span
class="MuiTypography-root MuiTypography-button"
>
Primary data
</span>
</div>
<div
aria-disabled="false"
aria-hidden="true"
class="MuiButtonBase-root MuiIconButton-root MuiAccordionSummary-expandIcon MuiAccordionSummary-expanded MuiIconButton-edgeEnd"
</span>
</div>
<div
aria-disabled="false"
aria-hidden="true"
class="MuiButtonBase-root MuiIconButton-root MuiAccordionSummary-expandIcon MuiAccordionSummary-expanded MuiIconButton-edgeEnd"
>
<span
class="MuiIconButton-label"
>
<span
class="MuiIconButton-label"
<svg
aria-hidden="true"
class="MuiSvgIcon-root makeStyles-expandIcon"
focusable="false"
viewBox="0 0 24 24"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root makeStyles-expandIcon"
focusable="false"
viewBox="0 0 24 24"
>
<path
d="M16.59 8.59L12 13.17 7.41 8.59 6 10l6 6 6-6z"
/>
</svg>
</span>
</div>
<path
d="M16.59 8.59L12 13.17 7.41 8.59 6 10l6 6 6-6z"
/>
</svg>
</span>
</div>
</div>
<div
class="MuiCollapse-container MuiCollapse-entered"
style="min-height: 0px;"
>
<div
class="MuiCollapse-container MuiCollapse-entered"
style="min-height: 0px;"
class="MuiCollapse-wrapper"
>
<div
class="MuiCollapse-wrapper"
class="MuiCollapse-wrapperInner"
>
<div
class="MuiCollapse-wrapperInner"
role="region"
>
<div
role="region"
class="MuiAccordionDetails-root makeStyles-expansionPanelDetails"
>
<div>
Core details
</div>
<div
class="MuiAccordionDetails-root makeStyles-expansionPanelDetails"
class="makeStyles-field"
>
<div
class="makeStyles-field"
class="makeStyles-fieldName"
>
<div
class="makeStyles-fieldName"
>
Position
</div>
<div
class="makeStyles-fieldValue"
>
<div>
ctgA:3..102 (+)
</div>
</div>
Position
</div>
<div
class="makeStyles-field"
class="makeStyles-fieldValue"
>
<div
class="makeStyles-fieldName"
>
Length
<div>
ctgA:3..102 (+)
</div>
<div
class="makeStyles-fieldValue"
>
<div>
100
</div>
</div>
</div>
<div
class="makeStyles-field"
>
<div
class="makeStyles-fieldName"
>
Length
</div>
<div
class="makeStyles-fieldValue"
>
<div>
100
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<hr
class="MuiDivider-root"
/>
<div
class="MuiPaper-root MuiAccordion-root MuiAccordion-expanded MuiAccordion-rounded MuiPaper-elevation1 MuiPaper-rounded"
style="margin-top: 4px;"
>
<div
aria-disabled="false"
aria-expanded="true"
class="MuiButtonBase-root MuiAccordionSummary-root MuiAccordionSummary-expanded"
role="button"
tabindex="0"
>
<div
class="MuiAccordionSummary-content MuiAccordionSummary-expanded"
>
<span
class="MuiTypography-root MuiTypography-button"
>
Attributes
</span>
</div>
<div
aria-disabled="false"
aria-hidden="true"
class="MuiButtonBase-root MuiIconButton-root MuiAccordionSummary-expandIcon MuiAccordionSummary-expanded MuiIconButton-edgeEnd"
>
<span
class="MuiIconButton-label"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root makeStyles-expandIcon"
focusable="false"
viewBox="0 0 24 24"
>
<path
d="M16.59 8.59L12 13.17 7.41 8.59 6 10l6 6 6-6z"
<hr
class="MuiDivider-root"
/>
</svg>
</span>
</div>
</div>
<div
class="MuiCollapse-container MuiCollapse-entered"
style="min-height: 0px;"
>
<div
class="MuiCollapse-wrapper"
>
<div
class="MuiCollapse-wrapperInner"
>
<div
role="region"
>
<div>
Attributes
</div>
<div
class="MuiAccordionDetails-root makeStyles-expansionPanelDetails"
class="makeStyles-field"
>
<div
class="makeStyles-field"
class="makeStyles-fieldName"
>
<div
class="makeStyles-fieldName"
>
score
</div>
<div
class="makeStyles-fieldValue"
>
<div>
37
</div>
score
</div>
<div
class="makeStyles-fieldValue"
>
<div>
37
</div>
</div>
</div>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,27 +1,37 @@
import React from 'react'
import { render } from '@testing-library/react'
import { observable } from 'mobx'
import { types } from 'mobx-state-tree'
import { ConfigurationSchema } from '@jbrowse/core/configuration'
import PluginManager from '@jbrowse/core/PluginManager'
import { stateModelFactory } from '.'

import VariantFeatureDetails from './VariantFeatureWidget'

describe('VariantTrack widget', () => {
it('renders with just the required model elements', () => {
const f = observable({
featureData: {
refName: 'ctgA',
start: 176,
end: 177,
name: 'rs123',
REF: 'A',
ALT: '<TRA>',
QUAL: 10.4,
INFO: {
MQ: 5,
},
const pluginManager = new PluginManager([])
const Session = types.model({
pluginManager: types.optional(types.frozen(), {}),
configuration: ConfigurationSchema('test', {}),
widget: stateModelFactory(pluginManager),
})
const model = Session.create({
widget: { type: 'VariantFeatureWidget' },
})
model.widget.setFeatureData({
refName: 'ctgA',
start: 176,
end: 177,
name: 'rs123',
REF: 'A',
ALT: '<TRA>',
QUAL: 10.4,
INFO: {
MQ: 5,
},
})

const { container } = render(<VariantFeatureDetails model={f} />)
const { container } = render(<VariantFeatureDetails model={model.widget} />)
expect(container.firstChild).toMatchSnapshot()
})
})
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import SimpleFeature, {
import { DataGrid } from '@material-ui/data-grid'
import { observer } from 'mobx-react'
import {
BaseFeatureDetails,
FeatureDetails,
BaseCard,
} from '@jbrowse/core/BaseFeatureWidget/BaseFeatureDetail'
import { getSession } from '@jbrowse/core/util'
Expand Down Expand Up @@ -210,11 +210,7 @@ function VariantFeatureDetails(props: any) {

return (
<Paper data-testid="variant-side-drawer">
<BaseFeatureDetails
feature={rest}
descriptions={descriptions}
{...props}
/>
<FeatureDetails feature={rest} descriptions={descriptions} {...props} />
<Divider />
{feat.type === 'breakend' ? (
<BreakendPanel
Expand Down
Loading

0 comments on commit d06760f

Please sign in to comment.