Avoid not allowing numeric 0

GMOD · Feb 26, 2024 · 9c93a5a · 9c93a5a
1 parent 9ab146c
commit 9c93a5a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 14 deletions.
diff --git a/plugins/linear-genome-view/src/LaunchLinearGenomeView/index.ts b/plugins/linear-genome-view/src/LaunchLinearGenomeView/index.ts
@@ -68,9 +68,8 @@ export default (pluginManager: PluginManager) => {
           const location = parseLocString(highlight, refName =>
             isValidRefName(refName, assembly),
           )
-          if (location?.start && location?.end) {
+          if (location?.start !== undefined && location?.end !== undefined) {
             location.assemblyName = assembly
-
             view.setHighlight(location)
           }
         }

diff --git a/plugins/linear-genome-view/src/LinearGenomeView/components/Highlight.tsx b/plugins/linear-genome-view/src/LinearGenomeView/components/Highlight.tsx
@@ -131,19 +131,17 @@ export const OverviewHighlight = observer(function OverviewHighlight({
 
   // coords
   const mapCoords = (r: ParsedLocStringA) => {
-    const s =
-      overview.bpToPx({
-        ...r,
-        coord: r.reversed ? r.end : r.start,
-      }) || 0
-
-    const e =
-      overview.bpToPx({
-        ...r,
-        coord: r.reversed ? r.start : r.end,
-      }) || 0
+    const s = overview.bpToPx({
+      ...r,
+      coord: r.reversed ? r.end : r.start,
+    })
 
-    return s && e
+    const e = overview.bpToPx({
+      ...r,
+      coord: r.reversed ? r.start : r.end,
+    })
+
+    return s !== undefined && e != undefined
       ? {
           width: Math.abs(e - s),
           left: s + cytobandOffset,