-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bring in all gene and transcript data, but disallow history (or use different uniquenames) if OGS #2401
Conversation
test input:
|
…a location (eg. genes) and not removing things from transcripts properly
notes:
If I extended this to |
This was the original one:
vs
Which is weird as this doesn't show up: even though the GFF3 is legal:
|
Need to confirm that the gene location is not sent or otherwise created on upload (which I think is the case). |
Sent this info:
Received:
GFF3:
|
When deleting the same GFF3 non-official from here it works:
when we add it as an official track:
I get the error:
which makes no sense as the database structure looks identical:
However, if we are replicating unique names. When loaded fresh however, its not a problem, so something else is going on during the deletion process. |
De novo features as official tracks are actually okay. Removing gene_products, provenance, etc. doesn't seem to have an effect. Deleting Something is wrong with the uniqueNames . . not sure. |
Original Test GFF3:
|
Note that the mRNA is the same, but the gene is missing from the imported evidence:
|
round-trip GFF3 is:
|
Seems to pull in everything but attributes, which is fine and potentially this is a good feature as important arbitrary attributes may be problematic. |
I think that this is going to be problematic to introduce this without a refactor |
fixes #2372
make work for GFF3 track: in https://github.com/GMOD/Apollo/blob/develop/grails-app/services/org/bbop/apollo/FeatureService.groovy#L1293 make sure that we pull in the additional properties if there (gene_product, provenance, comments, dbxref, go, etc. etct.)
Note: have to reload once official track is set.
TEST:
fill out all the way export
--type mRNA
)undo and redo without reloadinhibit undo / redo if not a full geneload attribute for everything left (need anexclude
list) or is this handled automatically in properties: note that they will have to be cast to lower-case on inputuseCDS
anduseName
and add test