Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation #282

Draft
wants to merge 11 commits into
base: Experimental-Mod-Pack
Choose a base branch
from

Conversation

UmbralReaper
Copy link
Collaborator

@UmbralReaper UmbralReaper commented Feb 14, 2021

Summary
Add i18n capabilities to the mod compilation.

Content
Add a script that extracts all the name and description strings from the JSON and a workflow that automates it.

  • Add locale folder
  • Integrate Gitlocalization.
  • Handle renaming files.
  • Handle moving files.
  • Handle deleting files.
  • Handle adding new files.
  • Handle .md files.
  • Support more JSON fields than just name and description.
  • Automate releases with alternate languages.

We could merge this now, but it would prevent doing any of the above (and wouldn't have any benefit).

Additional context
Even if nobody uses it, I still feel that we should give the option to translate mods.

@UmbralReaper UmbralReaper marked this pull request as draft February 14, 2021 09:59
@TheGoatGod TheGoatGod added the Experimental F every issue and pr should have this tag untill F release label Feb 14, 2021
@TheGoatGod
Copy link
Member

image

@TheGoatGod
Copy link
Member

please squash and merge I don't want to see this.
image

@UmbralReaper
Copy link
Collaborator Author

please squash and merge I don't want to see this.

Sure!

@UmbralReaper
Copy link
Collaborator Author

@TheGoatGod Travis CI appears to be failing.

@TheGoatGod TheGoatGod marked this pull request as ready for review February 15, 2021 12:29
@TheGoatGod TheGoatGod marked this pull request as draft February 15, 2021 12:30
@UmbralReaper
Copy link
Collaborator Author

UmbralReaper commented Feb 16, 2021

@TheGoatGod Why would you merge this? I explicitly stated that it wouldn't have any benefit!

We could merge this now, but it would prevent doing any of the above (and wouldn't have any benefit).

Even putting that aside, did you test it? Make sure that it worked properly? I certaintly haven't run any tests beyond a general smell check.

EDIT: cough. Seems that I misread the merge. I apologise for my mistake.

@UmbralReaper
Copy link
Collaborator Author

please squash and merge I don't want to see this.

This goes for you too. Let’s both endeavour to keep the commit history clean!
83DCCF6A-88A8-44BE-95F8-D0F506B3B26A

@TheGoatGod
Copy link
Member

https://github.com/GMC-Modding-Team/Community-Mod-Compilation-redux/pulls please move here, and i will be doing so in future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Experimental F every issue and pr should have this tag untill F release Translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants