fix: user service

GIP-RECIA · Jun 11, 2024 · 7faaa27 · 7faaa27
1 parent d536a6b
commit 7faaa27
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/src/main/java/fr/recia/collabsoft/service/db/UserService.java b/src/main/java/fr/recia/collabsoft/service/db/UserService.java
@@ -33,7 +33,15 @@ public class UserService {
   @Autowired
   private SoffitHolder soffitHolder;
 
+  private boolean isSubOk() {
+    final boolean isOk = soffitHolder.getSub() != null && !soffitHolder.getSub().startsWith("guest");
+    if (!isOk) log.debug("User is guest : sub \"{}\"", soffitHolder.getSub());
+
+    return isOk;
+  }
+
   public User getCurrentUser() {
+    if (!isSubOk()) return null;
     final User user = userRepository.findOne(
       QUser.user.casUid.eq(soffitHolder.getSub())
     ).orElse(null);
@@ -54,11 +62,7 @@ public User getUser(Long userId) {
   }
 
   public User createUser() {
-    if (soffitHolder.getSub() == null || soffitHolder.getSub().startsWith("guest")) {
-      log.debug("Unable to create user with sub \"{}\"", soffitHolder.getSub());
-
-      return null;
-    }
+    if (!isSubOk()) return null;
     if (getCurrentUser() != null) {
       log.debug("User with sub \"{}\" already exist", soffitHolder.getSub());