[processing] Fix errors and improve error handling #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-morvan
force-pushed
the
amorvan_fix_process
branch
from
7a02dd0 to
7b990e9
Compare
fvanderbiest
requested changes
May 31, 2017
| try: | ||
| logger.info('Reset all layer to not downloaded state.') | ||
| logger.info('Resetting all layer to not downloaded state.') |
|
|
||
|
|
||
| def upgrade(engine_name): | ||
| op.add_column('hazardset', sa.Column('processed_error', sa.String(), nullable=True), schema='processing') |
There was a problem hiding this comment.
I would rename processed_error into processing_error
thinkhazard/processing/completing.py
Outdated
| @@ -75,7 +80,8 @@ def do_execute(self, hazardset_id=None): | |||
| transaction.commit() | |||
| except Exception: | |||
| transaction.abort() | |||
| logger.error(traceback.format_exc()) | |||
| logger.error('An error occurred with {}'.format(id), | |||
There was a problem hiding this comment.
An error occurred with hazardset {}
arnaud-morvan
force-pushed
the
amorvan_fix_process
branch
2 times, most recently
from
0dd41e2 to
517a078
Compare
arnaud-morvan
force-pushed
the
amorvan_fix_process
branch
from
517a078 to
dd37f6d
Compare
|
@fvanderbiest : I've fixed tests and added some more tests in test_completing (last commit), if you can take a look. |
fvanderbiest
approved these changes
May 31, 2017
arnaud-morvan
force-pushed
the
amorvan_fix_process
branch
from
00923e7 to
927c968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relate #754