Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coefficient px,py,pz planes #253

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

psauvan
Copy link
Member

@psauvan psauvan commented Jul 8, 2024

If you are a first-time contributor to GEOUNED, please read our contributing guidelines:
https://github.com/GEOUNED-org/GEOUNED/blob/main/CONTRIBUTING.md

Description

Change way of writting parameters of PX, PY, PZ planes in output files. Instead of evaluating the parameter as the scalar product of the plane normal with a point on the plane, the x,y,z component of the plane is used.
This should fix some error when model dimensions are large.

Fixes issue

Please link to any issues that this PR fixes

Checklist

  • I'm making a PR from a feature branch on my fork into GEOUNED-org/GEOUNED/dev branch
  • I have followed PEP8 style guide for Python or run a formatter such as black or ruff format on my code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

psauvan added 2 commits July 8, 2024 11:41
values of PX, PY and PZ planes parameter have been from the value dot(axis,position) to position.x, position.y and position.z
@psauvan psauvan merged commit a23c96c into GEOUNED-org:dev Jul 8, 2024
9 checks passed
@psauvan psauvan deleted the Coefficient-PX,PY,PZ-planes branch July 12, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant