Added Error messages for when no cells are selected #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psauvan
requested changes
Feb 23, 2024
There was a problem hiding this comment.
We have set as default the exclusion of void materials because in general in CAD geometry only "solid" volume are defined. Moreover void cells are usually more complex and more difficult to translate.
Following this policy the commit on the reverse.ini file cannot be accepted. Anyway, as this file is only an example any user is free to configure this option at its convinience.
The other two commits would be accepted (I don't know how to do to accept only specific commits on a pull request)
|
I added another commit to undo the change. Probably not the most elegant way to do it. |
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried the reverse function and it took me a lot of time to find out why my output was empty. This error message will help users locate the reason.