Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical regridding - fixed-level to fixed-level #3055

Merged
merged 23 commits into from
Sep 26, 2024
Merged

Vertical regridding - fixed-level to fixed-level #3055

merged 23 commits into from
Sep 26, 2024

Conversation

pchakraborty
Copy link
Collaborator

@pchakraborty pchakraborty commented Sep 24, 2024 •
edited
Loading

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

  • Added a "new" VerticalRegridActionNew.F90 for reference. Not being exercised.
  • Moved VerticalRegridMethod_Flag into a new file
  • Added VerticalLinearMap.F90 that computes the linear interpolation matrix (src * matrix = dst) when regridding from fixed-levels src to fixed-levels dst
  • Added test generic3g/tests/Test_VerticalLinearMap.pf
  • Added Test_VerticalLinearMap.F90 for quick compilation and running. To be removed later.

Related Issue

@pchakraborty
Added a 'new' VerticalRegridAction for reference, not being exercised
e2da23c
@pchakraborty
Moved VerticalRegridMethod_Flag from VerticalRegridActionNew into a n…
a1fdd7b 
…ew module, VerticalRegridMethod
@pchakraborty
Moved VerticalRegridMethod.F90 from generic3g/actions and generic3g/v…
eb10574 
…ertical
@pchakraborty
Vertical regridding: fixed levels to fixed levels via subsetting
d6c5ba9
@pchakraborty
Added a local executable to test WeightComputation
cfc98db
@pchakraborty
finding bracket works
13f8ce7
@pchakraborty
Working weights for linear interp between fixed-levels and fixed-levels
e37b7c0
@pchakraborty
Better naming
b6dccb9
@pchakraborty
Added comment
2e514f2
@pchakraborty
Some renaming
9036118
@pchakraborty
Fixed Test_WeightComputation
0e70775
@pchakraborty
Renaming
11ced26
@pchakraborty
Added comments
1fc5860
@pchakraborty
Fixed routine name
8bed176
@pchakraborty
Using CSR_SparseMatrix
54972bb
@pchakraborty
Merge remote-tracking branch 'origin/release/MAPL-v3' into feature/pc…
fd79fa9 
…hakrab/vertical-regridding
@pchakraborty
Bug fix and cleanup. Added more test
2f4707e
@pchakraborty
Cleanup
512efc4
@pchakraborty pchakraborty added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related labels Sep 24, 2024
@pchakraborty pchakraborty marked this pull request as ready for review September 24, 2024 21:40
@pchakraborty pchakraborty requested a review from a team as a code owner September 24, 2024 21:40
tclune
tclune requested changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of minor changes and a few suggestions ... See inline comments.

@tclune tclune merged commit 6f236ab into release/MAPL-v3 Sep 26, 2024
36 checks passed
@tclune tclune deleted the feature/pchakrab/vertical-regridding branch September 26, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pchakraborty @tclune