Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read explicit "string" type of an attribute of a netcdf variable #3026

Merged
merged 2 commits into from
Sep 12, 2024
Merged

read explicit "string" type of an attribute of a netcdf variable #3026

merged 2 commits into from
Sep 12, 2024

Conversation

weiyuan-jiang
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • [] Tested this change with a run of GEOSgcm
  • [x ] Ran the Unit Tests (make tests)

Description

When a variable's attribute type is explicitly declared as 'string', it would be ignored by the formatter. This PR fixes that problem.

Related Issue

@weiyuan-jiang weiyuan-jiang added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Sep 11, 2024
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner September 11, 2024 16:52
tclune
tclune previously approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably should have asked you to submit this as a hotfix.

But there are also some conflicts. Checking into that.

@tclune
Copy link
Collaborator

tclune commented Sep 11, 2024

@weiyuan-jiang Please fix the conflicts in the CHANGELOG.

@tclune tclune closed this Sep 11, 2024
@weiyuan-jiang
Copy link
Contributor Author

@tclune Why it is closed? Do you want me to create another hot fix PR ?

@weiyuan-jiang weiyuan-jiang reopened this Sep 11, 2024
@tclune tclune self-requested a review September 12, 2024 12:28
@tclune
Copy link
Collaborator

tclune commented Sep 12, 2024

Closed? I did not close it.

@tclune tclune merged commit 0fe9a5e into develop Sep 12, 2024
36 checks passed
@tclune tclune deleted the feature/wjiang/read_string_attribute branch September 12, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiyuan-jiang @tclune