Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marginal progress on vertical grid support. #2979

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Marginal progress on vertical grid support. #2979

merged 3 commits into from
Aug 21, 2024

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Aug 21, 2024

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Introduced subclasses of VerticalGrid. Functionality is still very limited - got distracted by other events. But want these integrated for now.

Related Issue

@tclune tclune added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Aug 21, 2024
@tclune tclune requested a review from a team as a code owner August 21, 2024 13:01
@tclune tclune requested a review from bena-nasa August 21, 2024 13:01
@tclune tclune merged commit 5657109 into release/MAPL-v3 Aug 21, 2024
33 of 36 checks passed
@tclune tclune deleted the mapl3/tclune/more-vertical-grid-work branch August 21, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bena-nasa bena-nasa bena-nasa approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tclune @bena-nasa