Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GCC 14 issue with profiler test #2946

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Aug 5, 2024

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

This is a fix via @tclune for #2943. The odd thing is the ExclusiveColumn test is nigh-identical to this PercentageColumn test. Yet it doesn't seem to be triggered. 🤷🏼

Related Issue

Closes #2943

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Aug 5, 2024
@mathomp4 mathomp4 marked this pull request as ready for review August 5, 2024 14:57
@mathomp4 mathomp4 requested a review from a team as a code owner August 5, 2024 14:57
@tclune tclune merged commit 655868a into develop Aug 5, 2024
57 checks passed
@mathomp4 mathomp4 deleted the bugfix/mathomp4/2943-gcc14-fix-test branch August 5, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants