Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bubble up error from MAPL_getHorzIJindex function #2851

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented May 28, 2024

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Stop the program when the grid is not a normal CS grid but computes the IJindex. It partially addresses issue #2850 . Eventually, I think the Grid class should have information about stretch and the ij index is computed according to the info the grid provides

Related Issue

@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner May 28, 2024 19:43
@mathomp4
Copy link
Member

The main problem is, if we commit this, then we can't run the stretched grid with GOCART, right? And, well, I'm not sure if that's desired.

We might need to support some sort of "slower"/"dumber" IJ method if running stretched grid.

@mathomp4 mathomp4 marked this pull request as draft May 28, 2024 22:11
@mathomp4
Copy link
Member

I've drafted this PR until @tclune can have a think on it as well.

Copy link

github-actions bot commented Sep 7, 2024

This PR has been automatically marked as stale because it has not had activity in the last 60 days. If there are no updates within 7 days, it will be closed. You can add the ":hourglass: Long Term" label to prevent the stale action from closing this issue.

@github-actions github-actions bot added the ❄️ Stale This issue has been marked stale label Sep 7, 2024
@mathomp4 mathomp4 removed the ❄️ Stale This issue has been marked stale label Sep 19, 2024
@weiyuan-jiang weiyuan-jiang added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants