Remove ESMF_HAS_ACHAR_BUG CMake and cpp macro, update to ESMA_cmake v3.37.0 #2524
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
ESMF_HAS_ACHAR_BUG
CMake option and CPP macro that was used as a workaround for a NAG + ESMF bug. Testing by @metdyn and myself shows that this is no longer needed with ESMF 8.6.0.It also updates to ESMA_cmake v3.37.0 which sets the
ESMF_HAS_ACHAR_BUG
to defaultOFF
for now and will be removed in a later release.Related Issue
Motivation and Context
Let's NAG run ExtDataDriver.x!
How Has This Been Tested?
NAG only seems to run the tests correctly without this, so we turn it off. If we don't run NAG, we never use this, so it doesn't affect other compilers.
Types of changes
Checklist: