Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore MAPL Python2 import behavior #2496

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Dec 18, 2023

Description

As pointed out by @amdasilva, the MAPL Python interface inadvertently lost its Python2 behavior in re __init__.py. This restores that by adding back the from .foo import * lines.

Moreover, testing by @patricia-nasa found more bugs in the MAPL python code. Essentially, a lot of it was not Python3. Now it is.

Related Issue

Motivation and Context

Restores our MAPL Python behavior to pre-Python3.

How Has This Been Tested?

I'll probably ask @patricia-nasa to do some tests for me.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Dec 18, 2023
@mathomp4 mathomp4 self-assigned this Dec 18, 2023
@mathomp4 mathomp4 marked this pull request as ready for review December 20, 2023 19:28
@mathomp4 mathomp4 requested review from a team as code owners December 20, 2023 19:28
@mathomp4 mathomp4 merged commit ed7ba4e into develop Dec 20, 2023
23 checks passed
@mathomp4 mathomp4 deleted the feature/mathomp4/fix-up-python-init branch December 20, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants