-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic Code Generator Sample Code (0 diff) #2420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change requested.
@JulesKouatchou Can you also include a CHANGELOG entry about this as well (along with @tclune 's suggestion?) |
Not strongly opposed, but ... the directory is not the acg. It is stuff that uses the acg. Maybe obvious(ish) from context, but I'd prefer something that indicated that it does not in fact contain the ACG. |
Our usual convention is that gridcomps have the same name as the directory that they are in. Long story, but the convention got botched during early deployment so we have dirs like: |
|
…f the automatic code generator tool
# Conflicts: # CHANGELOG.md
I pushed a conflict fix up. I couldn't do it on the web. |
Description
spec
file and aCMakeLists.txt
file needed for the tool to work properly.Related Issue
Motivation and Context
The sample code is meant to provide an example on the necessary changes users need to introduce in their application if they want to use the automatic code generator tool.
How Has This Been Tested?
Our main task was to only make sure that the code could compile by generating the necessary
__.h
files (four of them). The code is not used to create any executable.Types of changes
Checklist: