Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark compilation issues on lassen / pecan with cpp17 + cuda11 #294

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

wrtobin
Copy link
Contributor

@wrtobin wrtobin commented Jun 29, 2023

No description provided.

Base automatically changed from cusini/cpp17Standard to develop July 1, 2023 02:13
Copy link
Collaborator

@corbett5 corbett5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you hand inlined makeRajaView and that fixed the problem? Not a huge fan of the solution, but it seems like a nasty problem...

Just curious if you tried changing the return type of makeRajaView to auto and or changed the variable assigned to from makeRajaView to auto. You never know what might trip up NVCC and get it to actually work haha.

@corbett5
Copy link
Collaborator

corbett5 commented Jul 1, 2023

@wrtobin, I just saw your commit message, I love it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants