Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak method names and update default dimensions #301

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

stefsmeets
Copy link
Contributor

This PR makes some small changes to the code after discussions with @v9lgraf @tfamprikis

  1. Rename ionic_conductivity to tracer_diffucivity_center_of_mass.
  2. Set default dimensions=3 (it can still be configured)
  3. Rename Orientations.conventional() -> Orientations.transform()

@stefsmeets stefsmeets mentioned this pull request Apr 9, 2024
6 tasks
@stefsmeets stefsmeets merged commit 7fa82c5 into main Apr 9, 2024
4 checks passed
@stefsmeets stefsmeets deleted the rename-haven branch April 9, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant