Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor 3d plots module #284

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Refactor 3d plots module #284

merged 3 commits into from
Mar 14, 2024

Conversation

stefsmeets
Copy link
Contributor

@stefsmeets stefsmeets commented Mar 14, 2024 •
edited
Loading

This PR revises the plot submodule and creates a single interface for all 3d plots: plots.plot_3d(). plots.density() and plots.jumps_3d() use the new function.

plots.plot_3d(structure=structure)
plots.plot_3d(jumps=jumps, structure=jumps.sites)
plots.plot_3d(paths=paths, volume=volume)
plots.plot_3d(volume=volume, structure=structure, lattice=volume.lattice)

@stefsmeets stefsmeets changed the title Refactor plots Refactor 3d plots module Mar 14, 2024
@stefsmeets stefsmeets marked this pull request as ready for review March 14, 2024 15:19
@stefsmeets stefsmeets merged commit e0dcdba into main Mar 14, 2024
5 checks passed
@stefsmeets stefsmeets deleted the refactor-plots branch March 14, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stefsmeets