Add method to extend trajectory #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @SCiarella , Could you review this PR and let me know what you think? |
|
I found this |
|
Ah, I should have checked. Yes that's way better! I will check if it works and then close this PR. Thanks! |
|
We may still need to have some custom code to make sure the extended trajectory is actually a gemdat trajectory. |
|
OK, seems like the pymatgen implementation covers our use case. I added a test so that we can keep track of this functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method to extend the current trajectory with another trajectory. I mimicked the api from
list.extend. Extending fails if any of the metadata (time step, lattice, etc) does not match.Closes #236