Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Feat: Create Home Screen, OnBoarding Screen #11

Merged
merged 20 commits into from
Jan 10, 2024

Conversation

bunju20
Copy link
Collaborator

@bunju20 bunju20 commented Jan 10, 2024

Issue

개발사항

image image

개선할 사항

  • onboarding 스크린은 있고 들어가는 로직은 없음

Copy link
Collaborator

@halfmoon-mind halfmoon-mind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했고, 작업된 부분 약간 코멘트 남긴 부분 확인해줘!

lib/views/home/home_screen.dart Outdated Show resolved Hide resolved
Comment on lines 1 to 8
List<String> sentences = [
'심장병 확률이 2.5% 올라갔어요.',
'암 확률이 3.5% 올라갔어요.',
'집에 보내주세요.',
'심장병 확률이 2.5% 올라갔어요.',
'암에 걸릴 확률이 3.5% 올라갔어요.',
'심장병 확률이 2.5% 올라갔어요.',
];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 부분은 controller에 있으면 될 것 같아요

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

말해주신거 전부 수정할게요! 피드백 증말로다가 감사합니다

@HyungJoonSon HyungJoonSon added feature New feature or request 현정 labels Jan 10, 2024
Copy link
Collaborator

@halfmoon-mind halfmoon-mind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@HyungJoonSon HyungJoonSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

@HyungJoonSon HyungJoonSon merged commit a5d13d5 into GDSC-snowflowerthon:develop Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request 현정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Feature ] - Create Home Screen, OnBoarding Screen
3 participants