Let all services report message_processing timings #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rngcntr
requested review from
FlorianHockmann,
pkemkes,
lisa0930 and
LarsSchlieper
pkemkes
approved these changes
Aug 24, 2023
| .ConfigureAwait(false); | ||
| } | ||
| await _publisher.PublishMessageAsync(message, token) | ||
| .ConfigureAwait(false); |
There was a problem hiding this comment.
nit: This could probably move into the line above and then we could even remove the parantheses of the if, if we want to.
| { | ||
| _messageProcessingTotal = | ||
| metricsFactory.CreateCounter("message_processing_total", "Message processing status total", false, "status"); |
There was a problem hiding this comment.
Note: We should make sure to put this breaking change into the release notes, when releasing this. Someone might be using this metric.
LarsSchlieper
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #940 by moving the metric from
MultiOutputServiceAdaptertoPrometheusDelegatingMessageHandlerand removes the now obsoletemessage_processing_totalmetric.