Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka commit issues #773

Closed
pstadermann opened this issue Mar 6, 2023 · 1 comment
Closed

Kafka commit issues #773

pstadermann opened this issue Mar 6, 2023 · 1 comment

Comments

@pstadermann
Copy link

Currently the KafkaConsumer has several commit issues:

  • Can skip failures!
    • If 9 messages are being retried and the 10. is processed succesfully, all 10 can be committed
  • No commit on shutdown
  • No way to commit every x ms

Unrelated to committing:

  • Cancel blocks until all polly retries are done

I'm working on a PR that will be finished soon.
pstadermann pushed a commit to pstadermann/motornet that referenced this issue Mar 8, 2023
Kafka commit issues GDATASoftwareAG#773
1188b95 
* Implementation
* Tests
pstadermann pushed a commit to pstadermann/motornet that referenced this issue Mar 8, 2023
Kafka commit issues GDATASoftwareAG#773
334a7ef 
Fix formatting
pstadermann pushed a commit to pstadermann/motornet that referenced this issue Mar 10, 2023
Kafka commit issues GDATASoftwareAG#773
d0f546e 
Changes for review
pstadermann pushed a commit to pstadermann/motornet that referenced this issue Mar 13, 2023
Kafka commit issues GDATASoftwareAG#773
72ad82a 
Final review fixes
pstadermann pushed a commit to pstadermann/motornet that referenced this issue Mar 13, 2023
Kafka commit issues GDATASoftwareAG#773
ba8d4d6 
dotnet format
pstadermann pushed a commit to pstadermann/motornet that referenced this issue Mar 14, 2023
Kafka commit issues GDATASoftwareAG#773
054d4cd 
* Implementation
* Tests
pstadermann pushed a commit to pstadermann/motornet that referenced this issue Mar 14, 2023
Kafka commit issues GDATASoftwareAG#773
3e65b55 
Set version to 0.12.0
pstadermann pushed a commit that referenced this issue Mar 14, 2023
Kafka commit issues #773
6fbfba4 
* Implementation
* Tests
pstadermann pushed a commit that referenced this issue Mar 14, 2023
Kafka commit issues #773
cb60e40 
Set version to 0.12.0
@FlorianHockmann
Copy link
Member

Fixed by #774

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pstadermann @FlorianHockmann