Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trackUnsaved prop to SelectFieldV2 #4811

Merged
merged 10 commits into from
Nov 22, 2022
Merged

Add trackUnsaved prop to SelectFieldV2 #4811

merged 10 commits into from
Nov 22, 2022

Conversation

JamesHuf
Copy link
Contributor

Resolves #4563.

Updates the SelectFieldV2 component to track unsaved changes by default and adds a new prop for disabling. Also adds a new story for the new prop being set to false.

To test:

  1. Navigate to the support page (/en/support)
  2. Confirm the select component looks/works as expected
  3. View the default story for the SelectFieldV2 and confirm it changes appearance appropriately.

@mnigh mnigh self-requested a review November 21, 2022 14:39
mnigh
mnigh requested changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@mnigh mnigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to address but nice progress!

frontend/talentsearch/src/js/components/support/SupportForm.tsx Show resolved Hide resolved
frontend/common/src/components/form/Select/SelectFieldV2.tsx Show resolved Hide resolved
frontend/common/src/components/form/Select/SelectFieldV2.stories.tsx Show resolved Hide resolved
@JamesHuf JamesHuf requested a review from mnigh November 21, 2022 22:32
mnigh
mnigh reviewed Nov 22, 2022
View reviewed changes
Copy link
Contributor

@mnigh mnigh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. I'm not sure about inputId={name}. @esizer, do you mind having a look or at least giving an explanation why this solution is the only option?

frontend/common/src/components/form/Select/SelectFieldV2.tsx Show resolved Hide resolved
@mnigh mnigh self-requested a review November 22, 2022 15:55
mnigh
mnigh approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@mnigh mnigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JamesHuf JamesHuf merged commit 7be984a into main Nov 22, 2022
@JamesHuf JamesHuf deleted the bug/4563-selectFieldV2-missing-trackUnsaved-prop branch November 22, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esizer esizer esizer left review comments

@mnigh mnigh mnigh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - SelectFieldV2 component missing trackUnsaved prop
3 participants
@JamesHuf @mnigh @esizer