Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Updates skill justification word limit #12395

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented Dec 30, 2024

🤖 Resolves #12163.

👋 Introduction

This PR updates the skill justification word limit in English and French.

🧪 Testing

  1. pnpm build
  2. Apply to a job advertisement
  3. Navigate to Step 5 of 7
  4. Connect a career timeline experience
  5. Verify Describe how you used this skill field has a word limit of 400
  6. Switch to French
  7. Verify Décrivez comment vous avez utilisé cette compétence field has a word limit of 560
  8. Navigate to http://localhost:8000/en/applicant/career-timeline/create
  9. Select type Work experience
  10. Click Add a skill button
  11. Verify Describe how this skill featured in this role field has a word limit of 400
  12. Switch to French
  13. Verify Décrivez la façon dont cette compétence a été mise en valeur dans ce rôle field has a word limit of 560

📸 Screenshots

Screen Shot 2024-12-30 at 12 18 47 Screen Shot 2024-12-30 at 12 19 20 Screen Shot 2024-12-30 at 12 35 29 Screen Shot 2024-12-30 at 12 34 25

Copy link
Member

@esizer esizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@mnigh mnigh added this pull request to the merge queue Dec 30, 2024
Merged via the queue into main with commit 229fc1c Dec 30, 2024
16 checks passed
@mnigh mnigh deleted the 12163-skill-justification-word-limit branch December 30, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Up the word limit on Skill justifications to 400 words in English, 560 in French.
2 participants