-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Backend for employee profile #12334
Conversation
Nope, I made a copy past error. Fixed in fix graphql input for employee profile |
Having trouble with returning any values (this after having run
Screen recordingScreen.Recording.2024-12-27.at.12.45.49.mov |
api/database/migrations/2024_12_18_133424_create_employee_profiles_table.php
Outdated
Show resolved
Hide resolved
api/database/migrations/2024_12_18_133424_create_employee_profiles_table.php
Show resolved
Hide resolved
dreamRoleWorkStream: WorkStream @belongsTo | ||
dreamRoleDepartments: [Department!] @belongsToMany | ||
|
||
userPublicProfile: UserPublicProfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue states: userPublicProfile: UserPublicProfile @self
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it work without self? Cause it should, @self
is when you want to reference the root model which this does not 🤔
@@ -602,6 +623,7 @@ type User { | |||
locationExemptions: String | |||
acceptedOperationalRequirements: [LocalizedOperationalRequirement] | |||
positionDuration: [PositionDuration] | |||
employeeProfile: EmployeeProfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue states: type employeeProfile: EmployeeProfile @self @canResolved(ability: "view")
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the last one, this is a different model than User
so @self
does not make sense here. Unless I just do not understand the @self
directive 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this field is about relationship between EmployeeProfile and UserPublicProfile, which are also different types. @self is not needed in here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have another reviewer on this PR before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just those questions , others looking great to me
|
||
case COACHING; | ||
case LEARNING; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exec coaching status
- Not participating
- Have a coach
- Is a coach
- Both coaching/learning
same question as Mentorship status below
Are we not storing Not participating as sep enum value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I envisioned it being an array.
[]
= not participatingnull
= not provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that works as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🤖 Resolves #12001
👋 Introduction
Adds the
EmployeeProfile
and all supporting code to the backend.🧪 Testing
applicant@test.com
by runningmake seed-fresh
/graphiql
applicant@test.com
(from env or bearer token)