Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish fpca regression example #552

Merged
merged 4 commits into from
Jul 2, 2023
Merged

Conversation

Ddelval
Copy link
Contributor

@Ddelval Ddelval commented Jun 30, 2023

Several issues have been addressed:

  • Fix the labels of the cross validation plot
  • Change cross validation plot style
  • Round scores to four decimal places

@Ddelval
Copy link
Contributor Author

Ddelval commented Jun 30, 2023

Blocked until tests are fixed ( #553 )

@Ddelval Ddelval requested a review from vnmabus June 30, 2023 22:24
Copy link
Member

@vnmabus vnmabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please store the results in a variable before printing (do not make f-strings that complicated).

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (680fc1e) 85.86% compared to head (9c19d28) 85.86%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #552   +/-   ##
========================================
  Coverage    85.86%   85.86%           
========================================
  Files          147      147           
  Lines        11649    11649           
========================================
  Hits         10002    10002           
  Misses        1647     1647           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ddelval Ddelval requested a review from vnmabus July 2, 2023 10:47
@vnmabus vnmabus merged commit 48fb0ad into develop Jul 2, 2023
@vnmabus vnmabus deleted the hotfix/fpca_regression_example branch August 17, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants