Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong variable name in fpca #478

Merged
merged 1 commit into from
Oct 2, 2022
Merged

Fix wrong variable name in fpca #478

merged 1 commit into from
Oct 2, 2022

Conversation

Ddelval
Copy link
Contributor

@Ddelval Ddelval commented Oct 2, 2022

The underscore at the end of the variable name was lost in refactoring in a previous commit.

@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Base: 84.96% // Head: 84.96% // No change to project coverage 👍

Coverage data is based on head (4f07cdb) compared to base (41f9f53).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #478   +/-   ##
========================================
  Coverage    84.96%   84.96%           
========================================
  Files          135      135           
  Lines        10731    10731           
========================================
  Hits          9118     9118           
  Misses        1613     1613           
Impacted Files Coverage Δ
skfda/preprocessing/dim_reduction/_fpca.py 91.20% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@vnmabus vnmabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vnmabus vnmabus merged commit 46fc684 into develop Oct 2, 2022
@vnmabus vnmabus deleted the hotfix/fpca_syntax branch August 17, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants