Update plot_kernel_smoothing.py #473
Conversation
ElenaPetrunina
commented
Aug 29, 2022
ElenaPetrunina
commented
- Fix runtime warning (division by zero)
- Change bandwidth values in CV parameter search
- Reorder sections
* Fix runtime warning (division by zero) * Change bandwidth values in CV parameter search * Reorder sections
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
examples/plot_kernel_smoothing.py
Outdated
| import skfda.preprocessing.smoothing.validation as val | ||
| from skfda.preprocessing.smoothing import KernelSmoother | ||
| from skfda.misc.kernels import uniform |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
I001 isort found an import in the wrong position
| import skfda.preprocessing.smoothing.validation as val | ||
| from skfda.preprocessing.smoothing import KernelSmoother | ||
| from skfda.misc.kernels import uniform | ||
| from skfda.misc.hat_matrix import ( |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
I001 isort found an import in the wrong position
There was a problem hiding this comment.
I reviewed the imports (and run isort in local) and they looks ordered to me. I am missing something?
There was a problem hiding this comment.
I will merge it and take a look at that later.
There was a problem hiding this comment.
Perfect, thanks
examples/plot_kernel_smoothing.py
Outdated
| import skfda.preprocessing.smoothing.validation as val | ||
| from skfda.preprocessing.smoothing import KernelSmoother | ||
| from skfda.misc.kernels import uniform | ||
| from skfda.misc.hat_matrix import ( | ||
| NadarayaWatsonHatMatrix, |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
I001 isort found an import in the wrong position
examples/plot_kernel_smoothing.py
Outdated
| from skfda.misc.kernels import uniform | ||
| from skfda.misc.hat_matrix import ( | ||
| NadarayaWatsonHatMatrix, | ||
| LocalLinearRegressionHatMatrix, |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
I001 isort found an import in the wrong position
| from skfda.misc.hat_matrix import ( | ||
| NadarayaWatsonHatMatrix, | ||
| LocalLinearRegressionHatMatrix, | ||
| KNeighborsHatMatrix, |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
I001 isort found an import in the wrong position
| NadarayaWatsonHatMatrix, | ||
| LocalLinearRegressionHatMatrix, | ||
| KNeighborsHatMatrix, | ||
| ) |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
I001 isort found an import in the wrong position
examples/plot_kernel_smoothing.py
Outdated
| dist = fd.grid_points[0][1] - fd.grid_points[0][0] | ||
| bandwidth = np.linspace( | ||
| dist, | ||
| dist*((n_neighbors[-1] - 1)//2), |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
E226 missing whitespace around arithmetic operator
examples/plot_kernel_smoothing.py
Outdated
| dist = fd.grid_points[0][1] - fd.grid_points[0][0] | ||
| bandwidth = np.linspace( | ||
| dist, | ||
| dist*((n_neighbors[-1] - 1)//2), |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
E226 missing whitespace around arithmetic operator
examples/plot_kernel_smoothing.py
Outdated
| bandwidth = np.linspace( | ||
| dist, | ||
| dist*((n_neighbors[-1] - 1)//2), | ||
| len(n_neighbors) |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
C815 missing trailing comma in Python 3.5+
Codecov Report
@@ Coverage Diff @@
## develop #473 +/- ##
========================================
Coverage 84.88% 84.88%
========================================
Files 135 135
Lines 10680 10680
========================================
Hits 9066 9066
Misses 1614 1614 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
examples/plot_kernel_smoothing.py
Outdated
| dataset = skfda.datasets.fetch_phoneme() | ||
| fd = dataset['data'][:300] | ||
|
|
||
| fd[:5].plot() | ||
| out = fd[:5].plot() |
There was a problem hiding this comment.
Better to leave without assignment AND add a plt.show() afterwards.
There was a problem hiding this comment.
Fixed, thanks.
* All out removed * Small changes in the text
