Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faucet endpoint should return 429 status code when interval has not expired #75

Open
zomglings opened this issue Sep 24, 2024 · 2 comments
Open

Faucet endpoint should return 429 status code when interval has not expired #75

zomglings opened this issue Sep 24, 2024 · 2 comments
Labels
api Protocol API issue bug Something isn't working

Comments

@zomglings
Copy link
Contributor

Currently, when a user requests funds from the faucet before their interval has expired, the API returns a 500 response.

This is not useful to the user - it would be more proper for the API to return a 429 response. The response should have the timestamp at which the user can once again use the faucet successfully in a header - x-game7-faucet-available-at or something like that.
@zomglings zomglings added bug Something isn't working api Protocol API issue labels Sep 24, 2024
gabrieltemtsen added a commit to gabrieltemtsen/protocol-game7 that referenced this issue Nov 28, 2024
@gabrieltemtsen
fix: Updated sendTokens to check remaining time before sending toke…
feb7b5e 
…ns and return 429 status code G7DAO#75
@gabrieltemtsen
Copy link
Contributor

Hi @zomglings please can I be assigned this issue

@gabrieltemtsen gabrieltemtsen mentioned this issue Nov 28, 2024
Open
@gabrieltemtsen
Copy link
Contributor

Hi @zomglings please can I be assigned this issue

@Andrei-Dolgolev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Protocol API issue bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zomglings @gabrieltemtsen