-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve required checks creation in CI #458
Conversation
5443460
to
ef845c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish Github CI did not require so much custom code -- seems like never ending maintenance if Armada Project is any guide.
After 4 years of using GitHub Actions, I wish so too 😞 |
This PR improves how we create the required check "All required checks succeeded" in the following ways: * We now use a GitHub app to create the check instead of using the token provided by GitHub Actions. This allows us to create the check run with its own check suite instead of attaching it to the first GHA check suite, which changes when a pull request is closed and reopened, or when a new run attempt is made. See https://github.com/orgs/community/discussions/24616#discussioncomment-6088422 for more details on this very annoying GitHub limitation. * A check is created and set as `queued` or `in_progress` when the corresponding workflow run's status changes. This is needed so that the check is reset when a new run attempt is made or a PR is reopened. * Logging is improved. * Start/Completion times are added.
This PR improves how we create the required check "All required checks succeeded" in the following ways: * We now use a GitHub app to create the check instead of using the token provided by GitHub Actions. This allows us to create the check run with its own check suite instead of attaching it to the first GHA check suite, which changes when a pull request is closed and reopened, or when a new run attempt is made. See https://github.com/orgs/community/discussions/24616#discussioncomment-6088422 for more details on this very annoying GitHub limitation. * A check is created and set as `queued` or `in_progress` when the corresponding workflow run's status changes. This is needed so that the check is reset when a new run attempt is made or a PR is reopened. * Logging is improved. * Start/Completion times are added.
This PR improves how we create the required check "All required checks succeeded" in the following ways:
This allows us to create the check run with its own check suite instead of attaching it to the first GHA check suite, which changes when a pull request is closed and reopened, or when a new run attempt is made. See https://github.com/orgs/community/discussions/24616#discussioncomment-6088422 for more details on this very annoying GitHub limitation.
queued
orin_progress
when the corresponding workflow run's status changes.This is needed so that the check is reset when a new run attempt is made or a PR is reopened.
The following tasks need to be completed before merging this PR:
check:write
permissionscreate-check
environment that can only be accessed by themain
branchThe following tasks need to be completed after merging this PR: