Close streams when Managed* classes are deleted #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "leaveOpen" parameter to opt out of this (same parameter name as StreamWriter/Reader).
herebebeasties
previously approved these changes
Nov 7, 2019
cpp/ManagedOutputStream.cpp
Outdated
| @@ -34,6 +35,10 @@ class ManagedOutputStream final : public arrow::io::OutputStream | |||
|
|
|||
| ~ManagedOutputStream() | |||
| { | |||
| arrow::Status st = this->Close(); | |||
| if (!st.ok()) { | |||
| ARROW_LOG(FATAL) << "Error ignored when destroying ManagedOutputStream: " << st; | |||
There was a problem hiding this comment.
Should this be FATAL if it's ignored and we carry on regardless? ERROR perhaps?
There was a problem hiding this comment.
Yes it should be ERROR.
|
I'll have some time to work on ParquetSharp end of next week. We've got a PR update to vcpkg Arrow that has been accepted, the latest releases of Arrow fixes quite a few Parquet bugs. |
Merged
|
Being merged into master as part of PR #77. Nuget package already built: https://www.nuget.org/packages/ParquetSharp/2.0.2-beta2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "leaveOpen" parameter to opt out of this (same parameter name as
StreamWriter/Reader).